Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the ng update command. The changes involve updating an example version from 10 to 21 and converting an absolute URL for the Angular Update Guide to a relative path. While the link change is a good improvement, the hardcoded version number in the example could quickly become outdated. I've provided a suggestion to rephrase the example to make it more robust and clearer for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
What is the new behavior?
Avoid using absolute links in angular.dev since this is an internal route.